fix(windows): reap republished daemons during nuke#657
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 989f8eaf45
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
nsxdavid
force-pushed
the
fix/windows-nuke-reap-daemons
branch
2 times, most recently
from
18d898d to
bc4f46a
Compare
nsxdavid
force-pushed
the
fix/windows-nuke-reap-daemons
branch
from
bc4f46a to
cfde602
Compare
|
👋 Thanks for the contribution! Quick heads-up: this repo lands changes on the current Please retarget this PR via Edit → base branch to the active (Automated hint — reply here if you need a hand.) |
|
Rebased onto the active |
nsxdavid
force-pushed
the
fix/windows-nuke-reap-daemons
branch
from
cfde602 to
9bf5148
Compare
|
Corrected per the repository guard: this PR now targets |
|
CI note: the new bench run stops before compilation because the release workflow cannot download its repository-pinned Zig archive ( |
1 participant
Summary
cli-daemon.pipeafter the visible owner exits are also terminated.cli-daemon.piperecords under{home}/.codedb/projectsand retain process-image verification before termination.Issue
No standalone issue exists; this addresses the post-merge Codex review note about multiple retry-mode Windows daemons.
Validation
zig build --global-cache-dir .zig-global-cache test-mcp -Dtest-filter="nuke" --summary all- 7/7 tests passedzig build --global-cache-dir .zig-global-cache test --summary all- 869/873 tests passed (4 skipped)zig build --global-cache-dir .zig-global-cache --summary all- 3/3 steps succeededPYTHONUTF8=1; python scripts/e2e_mcp_test.py --binary zig-out/bin/codedb.exe --project .- 20/20 passed on Windows using a repo-local test homegit diff --check- passed